Fix build by renaming apt docker dependency#529
Conversation
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
=======================================
Coverage 95.25% 95.25%
=======================================
Files 88 88
Lines 3961 3961
Branches 248 248
=======================================
Hits 3773 3773
Misses 137 137
Partials 51 51Continue to review full report at Codecov.
|
| @@ -11,9 +11,9 @@ venv: | |||
| .PHONY: dockerengine | |||
| dockerengine: | |||
There was a problem hiding this comment.
OK, at this point, I think we should
- drop this rule, it's no longer relevant. You will also have to remove it from the docs (installation)
- Remove travis provided docker in the travis yaml file.
- Have make deps do the docker installation (as it is doing now)
- Drop support for ubuntu 12, so...
| `lsb_release -cs` \ | ||
| stable" | ||
| -sudo apt-get -qq update | ||
| if [ `lsb_release -rs` = "14.04" ]; then \ |
There was a problem hiding this comment.
... don't bother with this one, because at this point the standard name is docker-engine for all versions.
There was a problem hiding this comment.
I kept it because the installed version of python wasn't the same, it is python3.4-venv for trusty and python3-venv for other versions
There was a problem hiding this comment.
Ok sorry I didn't understand this comment came with the other. I'll do it
| echo "ERROR: Cannot run on non-Linux systems"; \ | ||
| false; \ | ||
| fi | ||
| sudo apt-get remove docker docker-engine |
There was a problem hiding this comment.
in the travis. We don't want to remove a docker installation on the user's machine. if there's already a docker, it will just upgrade it.
Apparently something has changed at the docker apt repository, so the result is that the environment setup is compromised.