Skip to content

Add Simphony logo to the login page#528

Merged
martinRenou merged 5 commits into
masterfrom
add_enthought_logo
Jul 4, 2017
Merged

Add Simphony logo to the login page#528
martinRenou merged 5 commits into
masterfrom
add_enthought_logo

Conversation

@martinRenou

Copy link
Copy Markdown
Member

No description provided.

@stefanoborini

Copy link
Copy Markdown
Contributor

We need a simphony logo and it must be smaller.

@martinRenou martinRenou changed the title Add Enthought logo to the login page Add Simphony logo to the login page Jun 22, 2017
@codecov-io

codecov-io commented Jun 26, 2017

Copy link
Copy Markdown

Codecov Report

Merging #528 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   95.25%   95.27%   +0.02%     
==========================================
  Files          88       88              
  Lines        3961     4021      +60     
  Branches      248      252       +4     
==========================================
+ Hits         3773     3831      +58     
- Misses        137      138       +1     
- Partials       51       52       +1
Impacted Files Coverage Δ
remoteappmanager/handlers/base_handler.py 96.07% <0%> (-0.59%) ⬇️
remoteappmanager/base_application.py 97.6% <0%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7482382...1156c8f. Read the comment docs.

@stefanoborini

Copy link
Copy Markdown
Contributor

I would not put that file in jupyterhub. That directory is a "startup launchpad". Also, it won't be installed buy the setup that way.

@stefanoborini stefanoborini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a different location for the file, and setup installation for it.

@martinRenou

Copy link
Copy Markdown
Member Author

Should it be in the static directory of remoteappmanager ?

@martinRenou martinRenou merged commit 328d42f into master Jul 4, 2017
@martinRenou martinRenou deleted the add_enthought_logo branch July 4, 2017 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants