Add Simphony logo to the login page#528
Merged
Merged
Conversation
Contributor
|
We need a simphony logo and it must be smaller. |
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
==========================================
+ Coverage 95.25% 95.27% +0.02%
==========================================
Files 88 88
Lines 3961 4021 +60
Branches 248 252 +4
==========================================
+ Hits 3773 3831 +58
- Misses 137 138 +1
- Partials 51 52 +1
Continue to review full report at Codecov.
|
Contributor
|
I would not put that file in jupyterhub. That directory is a "startup launchpad". Also, it won't be installed buy the setup that way. |
stefanoborini
previously requested changes
Jun 26, 2017
stefanoborini
left a comment
Contributor
There was a problem hiding this comment.
We need a different location for the file, and setup installation for it.
Member
Author
|
Should it be in the static directory of remoteappmanager ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.