Skip to content

Application label refactor#519

Merged
stefanoborini merged 13 commits into
masterfrom
app-label-refactor
Jun 9, 2017
Merged

Application label refactor#519
stefanoborini merged 13 commits into
masterfrom
app-label-refactor

Conversation

@martinRenou

Copy link
Copy Markdown
Member
  • Rename "Stop application" link to "Quit"
  • Rename "Share (copy url)" link to "Share session"
  • Move share link above the quit link
  • Those links now opens modal dialogs
    • The share link opens a dialog with a a share button (which looks like the github clone button)
    • The quit link opens a confirm dialog before stopping the application

Closes #493 #512 #508 #513

@martinRenou

Copy link
Copy Markdown
Member Author

This needs selenium tests

module.exports = Vue.extend({
data: function() {
return { clipboardSupported: Clipboard.isSupported() };
return { shareDialogVisible: false, quitDialogVisible: false };

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shareDialog.visible

@martinRenou martinRenou changed the title Application label refactor [WIP] Application label refactor Jun 9, 2017
@codecov-io

codecov-io commented Jun 9, 2017

Copy link
Copy Markdown

Codecov Report

Merging #519 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #519   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files          88       88           
  Lines        3960     3960           
  Branches      248      248           
=======================================
  Hits         3772     3772           
  Misses        137      137           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e2e9ae...2fae7ec. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants