It is now more obvious when buttons are disabled#506
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
=======================================
Coverage 95.25% 95.25%
=======================================
Files 88 88
Lines 3960 3960
Branches 248 248
=======================================
Hits 3772 3772
Misses 137 137
Partials 51 51Continue to review full report at Codecov.
|
stefanoborini
suggested changes
Jun 6, 2017
| </li> | ||
| <li role="separator" class="divider"></li> | ||
| <ul class="dropdown-menu"> | ||
| <li class="header">Application settings</li> |
Contributor
There was a problem hiding this comment.
I would remove this entry here. It conflicts with HIG and brings in a problem we should not have to begin with.
| <template> | ||
| <ul v-if="currentApp !== null" class="nav navbar-nav"> | ||
| <li class="dropdown"> | ||
| <li class="dropdown notifications-menu"> |
Contributor
There was a problem hiding this comment.
removing the menu "section title" means that you don't need notification menu anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApplicationLabel changes.
Closes #487