Skip to content

Skip containers that are not found while checking container.items#478

Merged
stefanoborini merged 5 commits into
masterfrom
skip-missing-containers
Jun 5, 2017
Merged

Skip containers that are not found while checking container.items#478
stefanoborini merged 5 commits into
masterfrom
skip-missing-containers

Conversation

@stefanoborini

@stefanoborini stefanoborini commented May 31, 2017

Copy link
Copy Markdown
Contributor

The current webapi checks the accounting and fetches containers for the accounting data, but there was nothing to prevent operating on containers not active.

@codecov-io

codecov-io commented May 31, 2017

Copy link
Copy Markdown

Codecov Report

Merging #478 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
+ Coverage   95.33%   95.34%   +<.01%     
==========================================
  Files          88       88              
  Lines        4077     4085       +8     
  Branches      259      260       +1     
==========================================
+ Hits         3887     3895       +8     
  Misses        138      138              
  Partials       52       52
Impacted Files Coverage Δ
remoteappmanager/webapi/container.py 83.58% <100%> (+0.24%) ⬆️
remoteappmanager/webapi/tests/test_container.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff1154...ec8f7fe. Read the comment docs.

@stefanoborini stefanoborini requested a review from martinRenou June 5, 2017 08:46
@stefanoborini stefanoborini merged commit 75bfb77 into master Jun 5, 2017
@stefanoborini stefanoborini deleted the skip-missing-containers branch June 5, 2017 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants