Skip to content

Add share button in the ApplicationLabel component#469

Merged
stefanoborini merged 7 commits into
masterfrom
add_share_button
Jun 2, 2017
Merged

Add share button in the ApplicationLabel component#469
stefanoborini merged 7 commits into
masterfrom
add_share_button

Conversation

@martinRenou

Copy link
Copy Markdown
Member

When the user clicks on this share button, the application url is saved in the clipboard of the user and he can send this url to an other user

@codecov-io

codecov-io commented May 24, 2017

Copy link
Copy Markdown

Codecov Report

Merging #469 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #469   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files          88       88           
  Lines        4077     4077           
  Branches      259      259           
=======================================
  Hits         3887     3887           
  Misses        138      138           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e2d6b3...525dd1c. Read the comment docs.

<!-- Share button -->
<li
id="share-button"
:class="{ disabled: !currentApp.isRunning() || !clipboardSupported }"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deMorgan rule.

this.currentApp.appData.container.url_id
);
let output = this.currentApp.delayed ? url : url + '/';
let url = this.$options.filters.appUrl(this.currentApp);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are misusing filters here. filters are for templates, with the pipe notation. You never use that filter in a template context. It is a generic shared routine.

@stefanoborini

Copy link
Copy Markdown
Contributor

There's a problem with the npm build process. I get the following


ERROR in ./~/babel-loader/lib!./~/vue-loader/lib/selector.js?type=script&index=0!./frontend/user/vue-components/ApplicationLabel.vue
Module not found: Error: Can't resolve 'clipboard' in '/Users/sborini/Work/github/simphony/simphony-remote/frontend/user/vue-components'
 @ ./~/babel-loader/lib!./~/vue-loader/lib/selector.js?type=script&index=0!./frontend/user/vue-components/ApplicationLabel.vue 49:16-36
 @ ./frontend/user/vue-components/ApplicationLabel.vue
 @ ./frontend/user/main.js

ERROR in ./~/babel-loader/lib!./~/vue-loader/lib/selector.js?type=script&index=0!./frontend/user/vue-components/ApplicationLabel.vue
Module not found: Error: Can't resolve 'url-parse' in '/Users/sborini/Work/github/simphony/simphony-remote/frontend/user/vue-components'
 @ ./~/babel-loader/lib!./~/vue-loader/lib/selector.js?type=script&index=0!./frontend/user/vue-components/ApplicationLabel.vue 50:10-30
 @ ./frontend/user/vue-components/ApplicationLabel.vue
 @ ./frontend/user/main.js

This is due to the fact that I didn't have the appropriate packages installed. I opened an issue to include this operation in the build process.

@stefanoborini stefanoborini merged commit a1f3b2b into master Jun 2, 2017
@stefanoborini stefanoborini deleted the add_share_button branch June 2, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants