Create a component for the topbar#462
Conversation
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 88 88
Lines 4077 4077
Branches 259 259
=======================================
Hits 3887 3887
Misses 138 138
Partials 52 52Continue to review full report at Codecov.
|
| @@ -1,15 +1,5 @@ | |||
| <template> | |||
| <section class="sidebar"> | |||
| <!-- Error dialog --> | |||
There was a problem hiding this comment.
How do we report this now? I can't remember what we settled on.
There was a problem hiding this comment.
Now it's in ApplicationLabel.vue, and I had some tests for it in the corresponding test file.
The reason is that it's now the application label which have the stop button so it deals with a possible stopping error.
What I don't like with it is that the modal dialog is now inside a <ul> element in the ApplicationLabel template (which is weird because the modal dialog is not a <li>), I don't know how bad this is. It works, but it's weird.
A possible fix for that would be to send an event with the error message and an other view will deal with displaying this error, same for starting error.
This component (named ApplicationLabel) is a big dropdown button showing the current application running and its icon. When clicking on this button it displays application settings containing only the stop button for now. More settings could come later.
The stop buttons has been removed from the application list view.
This PR comes with big changes on the style of the user page. The top bar is now white, application icons are now squares with border radius of 20% instead of circles, the dropdown of the resolution widget is now less large.
Closes #415
Closes #376