Move frontend part in a specific directory#460
Merged
Conversation
| import subprocess | ||
| subprocess.check_call(['npm', 'run', 'build']) | ||
| subprocess.check_call(['npm', 'run', 'build-test']) | ||
| install.run(self) |
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 88 88
Lines 4077 4077
Branches 259 259
=======================================
Hits 3887 3887
Misses 138 138
Partials 52 52Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all the frontend (javascript and vue files) in a separate directory. Those files were previously in the remoteappmanager directory. The new directory is now named frontend.
This PR also changes the setup.py file so it now build the javascript when running
python setup.py install