Skip to content

Create Vue files and use vue-loader plugin of Webpack#458

Merged
stefanoborini merged 9 commits into
masterfrom
create_vue_files
May 18, 2017
Merged

Create Vue files and use vue-loader plugin of Webpack#458
stefanoborini merged 9 commits into
masterfrom
create_vue_files

Conversation

@martinRenou

@martinRenou martinRenou commented May 17, 2017

Copy link
Copy Markdown
Member

The changes are:

  • configure Webpack so that we can load .vue files
  • transpose old .js files containing Vue components into .vue files. It only results in splitting the template and the javascript into two separate tag elements <template> and <script> for each component.
  • application_list_view.js -> ApplicationListView.vue
  • user/views -> user/vue-components (to stay consistent with the admin)
  • configurables.js -> vue-components/configurables/Resolution.vue
  • user/models -> user/ApplicationListModel.js

@codecov-io

codecov-io commented May 17, 2017

Copy link
Copy Markdown

Codecov Report

Merging #458 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files          88       88           
  Lines        4077     4077           
  Branches      259      259           
=======================================
  Hits         3887     3887           
  Misses        138      138           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5efadd5...7584879. Read the comment docs.

@martinRenou martinRenou requested a review from stefanoborini May 17, 2017 17:03
@martinRenou martinRenou changed the title Create Vue files and use vue-loader plugin of Webpack Create Vue files and use vue-loader plugin of Webpack [WIP] May 18, 2017
In order to stay consistent with the admin part
In order to stay consistent with the admin part
Now models.js is ApplicationListModel.js
Now configurables.js is splitted into one configurables.js file which contains the models and *.vue files which contains the Vue components of the configurables
@martinRenou martinRenou changed the title Create Vue files and use vue-loader plugin of Webpack [WIP] Create Vue files and use vue-loader plugin of Webpack May 18, 2017
@stefanoborini stefanoborini merged commit ef3835a into master May 18, 2017
@stefanoborini stefanoborini deleted the create_vue_files branch May 18, 2017 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants