Add Webpack for creation of javascript bundles#452
Merged
Conversation
Vue was complaining that it couldn't find the dom elements with id #appview and #applist (containers for the Vue instances). I assume that, before using webpack, it was taking more time for the javascript to be loaded. So when the javascript code was starting to be executed, the whole page (including #appview and #applist) was already mounted. But now that the javascript file is minified, it takes less time to load it and execute it, and the dom elements are not ready yet. So we need to load the javascript only when the page is mounted. Meaning that the script element containing the javascript must be the last dom element of the body.
To resolve confusion between vue components and bower components. It will also permit to exclude properly bower components from babel (see next commit).
babel-loader will also add "use strict" in each functions automatically so we can tell jshint to not complaining about this.
It raises a "redefinition of $" but webpack will take care of it by adding jquery to the bundle only once
It will create a bundle of QUnit tests
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 88 88
Lines 4077 4077
Branches 259 259
=======================================
Hits 3887 3887
Misses 138 138
Partials 52 52Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.