Change error dialogs#450
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## switch_to_vue #450 +/- ##
==============================================
Coverage 95.33% 95.33%
==============================================
Files 88 88
Lines 4077 4077
Branches 259 259
==============================================
Hits 3887 3887
Misses 138 138
Partials 52 52Continue to review full report at Codecov.
|
stefanoborini
suggested changes
May 12, 2017
|
|
||
| resources.Container.delete(url_id) | ||
| return resources.Container.delete(url_id) | ||
| .done(function() { |
Contributor
There was a problem hiding this comment.
you don't have to do a done. Let the calling client handle the failure.
| @@ -154,18 +153,18 @@ define([ | |||
| configurablesData[tag] = configurable.asConfigDict(); | |||
| }); | |||
|
|
|||
Contributor
There was a problem hiding this comment.
create a promise. if you hit any of the fail, you resolve the promise by reject. otherwise, you say success.
| .fail(function(error) { | ||
| currentApp.status = Status.STOPPED; | ||
| dialogs.webapi_error_dialog(error); | ||
| return error; |
Contributor
There was a problem hiding this comment.
you have to add a done here to resolve the promise
| '<section class="sidebar">' + | ||
| '<section class="sidebar">' + | ||
| ' <!-- Error dialog -->' + | ||
| ' <confirm-dialog v-if="showErrorDialog"' + |
Contributor
There was a problem hiding this comment.
{
errorDialog: {
visible: true
}
}
| '<section class="sidebar">' + | ||
| ' <!-- Error dialog -->' + | ||
| ' <confirm-dialog v-if="showErrorDialog"' + | ||
| ' :title="getErrorTitle()"' + |
Contributor
There was a problem hiding this comment.
you just need {"whatever string "+errorMessage}
| return { 'searchInput': '' }; | ||
| return { | ||
| 'searchInput': '', | ||
| showErrorDialog: false, |
Contributor
There was a problem hiding this comment.
errorDialog: {
show: true,
message: ""
}
| var stoppingAppName = this.$options.filters.appName( | ||
| this.model.appList[index].appData.image); | ||
| this.model.stopApplication(index).fail(function(error) { | ||
| this.stoppingError = error; |
| this.showErrorDialog = true; | ||
| }.bind(this)); | ||
| }, | ||
| getErrorTitle: function() { |
| ' v-if="currentApp !== null"' + | ||
| ' :class="{ content: true, \'no-padding\': currentApp.isRunning() }">' + | ||
| ' <!-- Error dialog -->' + | ||
| ' <confirm-dialog v-if="showErrorDialog"' + |
And send the startApplication event to GA only if the start was a success
stefanoborini
approved these changes
May 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.