Skip to content

Change naming convention from snake_case to camelCase#446

Merged
stefanoborini merged 7 commits into
switch_to_vuefrom
change_naming_convention
May 11, 2017
Merged

Change naming convention from snake_case to camelCase#446
stefanoborini merged 7 commits into
switch_to_vuefrom
change_naming_convention

Conversation

@martinRenou

Copy link
Copy Markdown
Member

No description provided.

@codecov-io

codecov-io commented May 11, 2017

Copy link
Copy Markdown

Codecov Report

Merging #446 into switch_to_vue will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           switch_to_vue     #446   +/-   ##
==============================================
  Coverage          95.33%   95.33%           
==============================================
  Files                 88       88           
  Lines               4077     4077           
  Branches             259      259           
==============================================
  Hits                3887     3887           
  Misses               138      138           
  Partials              52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a90d862...0d615b1. Read the comment docs.

@martinRenou martinRenou changed the title Change naming convention from snake_case to camelCase [WIP] Change naming convention from snake_case to camelCase May 11, 2017
return (
icon_data ?
'data:image/png;base64,' + icon_data :
urlutils.path_join(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pathJoin.

"components/vue/dist/vue",
"urlutils"
], function (Vue, urlutils) {
], function (Vue, urlUtils) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question is if we should use the same for modules, or just stick to the filename (all lowercase).

But we use Vue... but then again, Vue is also weird because it's a class...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted to stay consistent in all files (except for the variables which come from the server). But if I rename it urlUtils I should maybe rename the file as well ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

google style guide says lowercase for filenames.. so no, the file is urlutils...

Leave it as is.

@stefanoborini stefanoborini merged commit f402a51 into switch_to_vue May 11, 2017
@stefanoborini stefanoborini deleted the change_naming_convention branch May 11, 2017 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants