Introduced data-table and confirm-dialog components: User#437
Merged
Conversation
martinRenou
previously requested changes
May 10, 2017
| ' v-if="newUserDialog.show"' + | ||
| ' :show="newUserDialog.show"' + | ||
| ' @created="newUserCreated"' + | ||
| ' @closed="newUserDialogClosed"></new-user-dialog>' + |
Member
There was a problem hiding this comment.
@closed="newUserDialog.show = false" and remove the newUserDialogClosed method ? It will save 4 lines of code
| ' </data-table>' + | ||
| ' <new-user-dialog ' + | ||
| ' v-if="newUserDialog.show"' + | ||
| ' :show="newUserDialog.show"' + |
Contributor
Author
There was a problem hiding this comment.
the new dialog needs to know if it's visible at the moment, so it needs that information. I am leaving the New dialogs unchanged for the moment, because I need a better dialog for them (and I am not sure it's worth extracting it)
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 88 88
Lines 4077 4077
Branches 259 259
=======================================
Hits 3887 3887
Misses 138 138
Partials 52 52Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change to Users page. Uses toolkit components data-table and confirm-dialog.