Skip to content

Added toolkit of useful components#434

Merged
stefanoborini merged 4 commits into
masterfrom
toolkit-entries
May 10, 2017
Merged

Added toolkit of useful components#434
stefanoborini merged 4 commits into
masterfrom
toolkit-entries

Conversation

@stefanoborini

Copy link
Copy Markdown
Contributor

Adds the following components:

  • data-table: represents a table of data.
  • confirm-dialog: a modal dialog to confirm or reject something
  • modal-dialog: as before, but just put in toolkit now

@codecov-io

codecov-io commented May 9, 2017

Copy link
Copy Markdown

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #434   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files          88       88           
  Lines        4077     4077           
  Branches      259      259           
=======================================
  Hits         3887     3887           
  Misses        138      138           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6fd77...3c40edc. Read the comment docs.

@stefanoborini stefanoborini requested a review from martinRenou May 9, 2017 21:51
' <div class="col-md-12">' +
' <div class="box">' +
' <div class="box-header with-border"><slot name="header">{{title}}</slot></div>' +
' <div class="box-body"><slot></slot></div>' +

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need a named slot here too ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I keep it anonymous so everything that is between the component markers is embedded there.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok :)

type: Function,
default: function() {}
},
errorMessage: {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You never use this errorMessage

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

thanks.

},
buttonClassFromType: function(value) {
var cls = {"btn": true};
if (value === undefined) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With ES6 we will use a default value like in python function(value = "danger"){...}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we need to move to babel so we can code like civilised people.

@stefanoborini stefanoborini merged commit c2bdf22 into master May 10, 2017
@stefanoborini stefanoborini deleted the toolkit-entries branch May 10, 2017 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants