Skip to content

Now use dev mode with Vue#431

Merged
stefanoborini merged 2 commits into
switch_to_vuefrom
use_dev_mode
May 9, 2017
Merged

Now use dev mode with Vue#431
stefanoborini merged 2 commits into
switch_to_vuefrom
use_dev_mode

Conversation

@martinRenou

Copy link
Copy Markdown
Member

No description provided.

@martinRenou martinRenou requested a review from stefanoborini May 9, 2017 15:20
@martinRenou

martinRenou commented May 9, 2017

Copy link
Copy Markdown
Member Author

Ok, I would expect that loading the minified version or the dev version wouldn't affect the tests. However, I suspect that jQuery is the reason of the failure because an error $ is not a function is raised in the console with the dev version (hidden with the min version). So once the PR #422 is merged I think (hope) the tests will pass.

@codecov-io

codecov-io commented May 9, 2017

Copy link
Copy Markdown

Codecov Report

Merging #431 into switch_to_vue will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           switch_to_vue     #431   +/-   ##
==============================================
  Coverage          95.33%   95.33%           
==============================================
  Files                 88       88           
  Lines               4077     4077           
  Branches             259      259           
==============================================
  Hits                3887     3887           
  Misses               138      138           
  Partials              52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed2eca...1a8d281. Read the comment docs.

@stefanoborini stefanoborini merged commit dbc42a7 into switch_to_vue May 9, 2017
@stefanoborini stefanoborini deleted the use_dev_mode branch May 9, 2017 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants