Skip to content

Add transition effect#423

Merged
martinRenou merged 12 commits into
switch_to_vuefrom
add_transitions
May 11, 2017
Merged

Add transition effect#423
martinRenou merged 12 commits into
switch_to_vuefrom
add_transitions

Conversation

@martinRenou

Copy link
Copy Markdown
Member

Add a fade effect. This effect will be applied only when starting and stopping the application, not when switching from a running application to a stopped application.

@martinRenou martinRenou requested a review from stefanoborini May 5, 2017 09:36
@martinRenou

Copy link
Copy Markdown
Member Author

We agreed that it should be a simple fade instead of a sliding fade

@martinRenou martinRenou changed the title Add transition effect Add transition effect [WIP] May 5, 2017
@codecov-io

codecov-io commented May 8, 2017

Copy link
Copy Markdown

Codecov Report

Merging #423 into switch_to_vue will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           switch_to_vue     #423   +/-   ##
==============================================
  Coverage          95.33%   95.33%           
==============================================
  Files                 88       88           
  Lines               4077     4077           
  Branches             259      259           
==============================================
  Hits                3887     3887           
  Misses               138      138           
  Partials              52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c85c168...eb96180. Read the comment docs.

@martinRenou martinRenou changed the title Add transition effect [WIP] Add transition effect May 9, 2017
Comment thread selenium_tests/test_hide_application.py Outdated
driver.find_element_by_css_selector(
"#applistentries > li").value_of_css_property(
'display') == "none")
WebDriverWait(driver, 3).until(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this.

@martinRenou martinRenou merged commit a628f23 into switch_to_vue May 11, 2017
@martinRenou martinRenou deleted the add_transitions branch May 11, 2017 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants