Skip to content

Renamed some entities to more appropriate names#419

Merged
stefanoborini merged 5 commits into
masterfrom
rename-get-apps-for-user
May 4, 2017
Merged

Renamed some entities to more appropriate names#419
stefanoborini merged 5 commits into
masterfrom
rename-get-apps-for-user

Conversation

@stefanoborini

Copy link
Copy Markdown
Contributor

The following changes have been introduced:

  • The term Accounting now refers exclusively to the relationship table connecting users, applications and policies.
  • The config file accounting_class and accounting_kwargs are now database_class and database_kwargs.
  • AppAccounting is now ORMDatabase. Similarly, CSVAccounting is now CSVDatabase.

The above two break compatibility with the old configuration files. As a result, it's important to bump the version to 2.0

@codecov-io

codecov-io commented May 3, 2017

Copy link
Copy Markdown

Codecov Report

Merging #419 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   95.24%   95.26%   +0.01%     
==========================================
  Files          96       96              
  Lines        4102     4114      +12     
  Branches      255      254       -1     
==========================================
+ Hits         3907     3919      +12     
  Misses        143      143              
  Partials       52       52
Impacted Files Coverage Δ
...teappmanager/webapi/admin/tests/test_accounting.py 100% <ø> (ø) ⬆️
remoteappmanager/webapi/admin/tests/test_user.py 100% <ø> (ø) ⬆️
...eappmanager/webapi/admin/tests/test_application.py 100% <ø> (ø) ⬆️
remoteappmanager/db/csv_db.py 98.75% <100%> (+0.03%) ⬆️
remoteappmanager/base_application.py 97.67% <100%> (ø) ⬆️
remoteappmanager/db/tests/test_interfaces.py 100% <100%> (ø) ⬆️
remoteappmanager/db/tests/abc_test_interfaces.py 87.01% <100%> (ø) ⬆️
remoteappmanager/file_config.py 96.66% <100%> (ø) ⬆️
remoteappmanager/db/interfaces.py 100% <100%> (ø) ⬆️
remoteappmanager/tests/test_application.py 100% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d201ec1...8e26eca. Read the comment docs.

@stefanoborini stefanoborini requested a review from martinRenou May 3, 2017 20:30
@stefanoborini stefanoborini merged commit ddebdf9 into master May 4, 2017
@stefanoborini stefanoborini deleted the rename-get-apps-for-user branch May 4, 2017 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants