Fix search form behavior#417
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## switch_to_vue #417 +/- ##
==============================================
Coverage 95.24% 95.24%
==============================================
Files 96 96
Lines 4102 4102
Branches 255 255
==============================================
Hits 3907 3907
Misses 143 143
Partials 52 52Continue to review full report at Codecov.
|
stefanoborini
suggested changes
May 4, 2017
| }, | ||
|
|
||
| computed: { | ||
| 'entries_visible': function() { |
Contributor
There was a problem hiding this comment.
you don't need a visibility array. What you need is a filtering operation over the model vs represented model.
| }, | ||
|
|
||
| computed: { | ||
| 'entries_visible': function() { |
Contributor
There was a problem hiding this comment.
Also, this one is new behavior so you need a selenium test for it
stefanoborini
approved these changes
May 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploys correct behavior for search, restricting to the applications that are relevant to the search itself.