Create google analytics observer#411
Merged
Merged
Conversation
It watches the current application status, and when the application starts, send the appropriate event.
Codecov Report
@@ Coverage Diff @@
## switch_to_vue #411 +/- ##
================================================
Coverage ? 95.24%
================================================
Files ? 96
Lines ? 4102
Branches ? 255
================================================
Hits ? 3907
Misses ? 143
Partials ? 52Continue to review full report at Codecov.
|
Using a Vue object listening to the current_app.status variable results in issues when current_app is changing. Because if current_app changes (when clicking on a new application) and the new clicked application does not have the same status as the previous one, the event is triggered. We now use the emit method to solve this issue
stefanoborini
approved these changes
May 2, 2017
| }; | ||
|
|
||
| return { | ||
| init: init, // For testing purpose |
Contributor
There was a problem hiding this comment.
at this point, init could be a method of GaObserver. Keep it separate, because we still need to patch it at the test level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.