Refactor model#407
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## switch_to_vue #407 +/- ##
==============================================
Coverage 95.15% 95.15%
==============================================
Files 94 94
Lines 4047 4047
Branches 254 254
==============================================
Hits 3851 3851
Misses 143 143
Partials 53 53Continue to review full report at Codecov.
|
And adapt the model so that Vue is aware of the app_list changes.
Will be enable in the next PR, ga will be a Vue object which react to model changes
martinRenou
commented
Apr 28, 2017
| "use strict"; | ||
|
|
||
| var Status = utils.Status; | ||
| // var ga = gamodule.init(); |
| // Add the options for some image types | ||
| app_data.forEach(function(application_data, data_idx) { | ||
| this.app_list[data_idx] = { app_data: application_data }; | ||
| this.app_list.push({ |
Member
Author
There was a problem hiding this comment.
You can set the value in a single shot, saves in performance.
| app_list_view.model = model; | ||
| app_view.model = model; | ||
| new application_view.ApplicationView({ // jshint ignore:line | ||
| el: 'div.content-wrapper', |
Member
Author
There was a problem hiding this comment.
add an ID to that specific snippet.
| '../../components/vue/dist/vue.min', | ||
| "jsapi/v1/resources" | ||
| ], function ($, urlutils, utils, gamodule, dialogs, models, Vue, resources) { | ||
| '../../components/vue/dist/vue.min' |
Member
Author
There was a problem hiding this comment.
you can use vue instead of vue.min
stefanoborini
approved these changes
Apr 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.