Skip to content

Update against new tornado webapi#403

Merged
martinRenou merged 12 commits into
masterfrom
update-tornado-webapi
Apr 25, 2017
Merged

Update against new tornado webapi#403
martinRenou merged 12 commits into
masterfrom
update-tornado-webapi

Conversation

@stefanoborini

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io

codecov-io commented Apr 24, 2017

Copy link
Copy Markdown

Codecov Report

Merging #403 into master will decrease coverage by 0.01%.
The diff coverage is 99.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   95.17%   95.15%   -0.02%     
==========================================
  Files          94       94              
  Lines        3996     4047      +51     
  Branches      256      254       -2     
==========================================
+ Hits         3803     3851      +48     
- Misses        139      143       +4     
+ Partials       54       53       -1
Impacted Files Coverage Δ
remoteappmanager/application.py 100% <100%> (ø) ⬆️
remoteappmanager/base_application.py 97.67% <100%> (ø) ⬆️
remoteappmanager/admin_application.py 100% <100%> (ø) ⬆️
remoteappmanager/webapi/admin/__init__.py 100% <100%> (ø) ⬆️
remoteappmanager/webapi/admin/accounting.py 87.17% <100%> (-7.27%) ⬇️
remoteappmanager/webapi/container.py 83.33% <100%> (+0.93%) ⬆️
remoteappmanager/webapi/tests/test_application.py 100% <100%> (ø) ⬆️
remoteappmanager/webapi/admin/application.py 100% <100%> (ø) ⬆️
remoteappmanager/webapi/tests/test_container.py 100% <100%> (ø) ⬆️
remoteappmanager/webapi/application.py 100% <100%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5725ffe...86d697c. Read the comment docs.

.done(function (identifiers, items) {
var result = [];
for (var key in items) {
if (!items.hasOwnProperty(key)) {

@martinRenou martinRenou Apr 25, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can replace this loop and the if statement with something like:

Object.keys(items).forEach(function(key){
    result.push(items[key]);
});

@martinRenou martinRenou merged commit 6f6bdd8 into master Apr 25, 2017
@martinRenou martinRenou deleted the update-tornado-webapi branch April 25, 2017 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants