Pinning against specific version of Jupyterhub to fix red.#396
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #396 +/- ##
=========================================
Coverage ? 95.17%
=========================================
Files ? 94
Lines ? 3996
Branches ? 256
=========================================
Hits ? 3803
Misses ? 139
Partials ? 54Continue to review full report at Codecov.
|
Contributor
Author
|
Error due to missing coverage. Good to go. |
Contributor
Author
|
Further kept track on pr #396 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently something has changed upstream in jupyterhub so that it makes our master red.
I pinned against 2d1a45f0190059ef436c2f97dc8d6e391eb2d139 for now, but the problem needs to be investigated further.