Skip to content

Virtual docker cleanup#389

Merged
stefanoborini merged 19 commits into
masterfrom
virtual-docker-cleanup
Apr 6, 2017
Merged

Virtual docker cleanup#389
stefanoborini merged 19 commits into
masterfrom
virtual-docker-cleanup

Conversation

@stefanoborini

@stefanoborini stefanoborini commented Apr 3, 2017

Copy link
Copy Markdown
Contributor

Refactoring of the Virtual Docker to make it more extensible.
Introduced the VirtualDockerClient to behave like a normal dockerpy client.
Disambiguated many confusing names, and followed a more consistent approach to ids.

@codecov-io

codecov-io commented Apr 3, 2017

Copy link
Copy Markdown

Codecov Report

Merging #389 into master will decrease coverage by 0.07%.
The diff coverage is 97.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
- Coverage   95.24%   95.17%   -0.08%     
==========================================
  Files          94       94              
  Lines        3998     3996       -2     
  Branches      258      256       -2     
==========================================
- Hits         3808     3803       -5     
- Misses        133      139       +6     
+ Partials       57       54       -3
Impacted Files Coverage Δ
remoteappmanager/docker/container_manager.py 82.48% <0%> (-3.69%) ⬇️
.../handlers/tests/test_register_container_handler.py 100% <100%> (ø) ⬆️
...ppmanager/docker/tests/test_async_docker_client.py 100% <100%> (ø) ⬆️
...eappmanager/docker/tests/test_container_manager.py 100% <100%> (ø) ⬆️
remoteappmanager/cli/tests/test_remoteappdb.py 100% <100%> (ø) ⬆️
remoteappmanager/tests/test_command_line_config.py 100% <100%> (ø) ⬆️
remoteappmanager/docker/tests/test_image.py 100% <100%> (ø) ⬆️
remoteappmanager/webapi/admin/tests/test_user.py 100% <100%> (ø) ⬆️
...eappmanager/webapi/admin/tests/test_application.py 100% <100%> (ø) ⬆️
...teappmanager/webapi/admin/tests/test_accounting.py 100% <100%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 899376d...7e883c1. Read the comment docs.

@stefanoborini stefanoborini changed the title Virtual docker cleanup [WIP] Virtual docker cleanup Apr 6, 2017
@stefanoborini stefanoborini merged commit 5dadfdf into master Apr 6, 2017
@stefanoborini stefanoborini deleted the virtual-docker-cleanup branch April 6, 2017 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants