Skip to content

Made the async docker client instance private#360

Merged
stefanoborini merged 2 commits into
masterfrom
private-docker-client
Mar 8, 2017
Merged

Made the async docker client instance private#360
stefanoborini merged 2 commits into
masterfrom
private-docker-client

Conversation

@stefanoborini

Copy link
Copy Markdown
Contributor

There is no reason why the ContainerManager should export the docker client publicly.

@codecov-io

codecov-io commented Mar 8, 2017

Copy link
Copy Markdown

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files          92       92           
  Lines        3895     3895           
  Branches      253      253           
=======================================
  Hits         3710     3710           
  Misses        127      127           
  Partials       58       58
Impacted Files Coverage Δ
remoteappmanager/tests/mocking/dummy.py 91.46% <100%> (ø)
...eappmanager/docker/tests/test_container_manager.py 100% <100%> (ø)
remoteappmanager/docker/container_manager.py 85.64% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46798b4...c15d5d1. Read the comment docs.

@stefanoborini stefanoborini merged commit 0d900f2 into master Mar 8, 2017
@stefanoborini stefanoborini deleted the private-docker-client branch March 9, 2017 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants