Skip to content

Changes whitelist handling to cope with jupyterhub.#359

Merged
stefanoborini merged 4 commits into
masterfrom
fix-file-whitelist
Mar 8, 2017
Merged

Changes whitelist handling to cope with jupyterhub.#359
stefanoborini merged 4 commits into
masterfrom
fix-file-whitelist

Conversation

@stefanoborini

Copy link
Copy Markdown
Contributor

Addresses the following issues:

  • adds config=True to allow the option to be set at config time.
  • returns a copy of the set, because jupyterhub changes it.
  • added mock setter to pacify jupyterhub.

@codecov-io

codecov-io commented Mar 8, 2017

Copy link
Copy Markdown

Codecov Report

Merging #359 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   95.23%   95.25%   +0.01%     
==========================================
  Files          92       92              
  Lines        3885     3895      +10     
  Branches      253      253              
==========================================
+ Hits         3700     3710      +10     
  Misses        127      127              
  Partials       58       58
Impacted Files Coverage Δ
.../jupyterhub/auth/github_whitelist_authenticator.py 100% <100%> (ø)
.../auth/tests/test_github_whitelist_authenticator.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2f853...4421e77. Read the comment docs.

@stefanoborini stefanoborini merged commit 46798b4 into master Mar 8, 2017
@stefanoborini stefanoborini deleted the fix-file-whitelist branch March 8, 2017 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants