Skip to content

Remove sudo in npm install #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanoborini merged 1 commit into from
Sep 19, 2016
Merged

Remove sudo in npm install #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ jupyterhub_cookie_secret
*.key
doc/build
doc/source/api
doc/source/remoteappmanager_help.txt
doc/source/remoteappmanager_help.txt
node_modules
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ deps:
sudo apt-get install -o Dpkg::Options::="--force-confold" --force-yes -y docker-engine npm nodejs-legacy python3-pip python3.4-venv
pip3 install --upgrade pip setuptools
# Currently set to 1.4.0dev fixing X-Forward behavior
sudo npm install -g "git://github.com/jupyterhub/configurable-http-proxy.git#f54c6a46a235f17cb6c36046a913d37fa45ec95b"
npm install "git://github.com/jupyterhub/configurable-http-proxy.git#f54c6a46a235f17cb6c36046a913d37fa45ec95b"
pip3 install -r requirements.txt

.PHONY: devdeps
Expand Down
7 changes: 7 additions & 0 deletions jupyterhub/start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,8 @@
if [ "${0:0:1}" = '/' ]; then
SCRIPT_DIR=`dirname "$0"`
else
cwd=`pwd`
SCRIPT_DIR=`dirname "$cwd/$0"`
fi
export PATH=$SCRIPT_DIR/../node_modules/.bin/:$PATH
jupyterhub --ssl-key test.key --ssl-cert test.crt