File Config is no longer a requirement for remoteappmanager#170
Merged
stefanoborini merged 8 commits intoJul 27, 2016
Merged
Conversation
Contributor
Author
|
Need to update the doc for this change. |
Current coverage is 86.32% (diff: 100%)@@ master #170 diff @@
==========================================
Files 36 35 -1
Lines 1379 1360 -19
Methods 0 0
Messages 0 0
Branches 130 131 +1
==========================================
Hits 1174 1174
+ Misses 166 148 -18
+ Partials 39 38 -1
|
| def test_args_without_config_file_path(self): | ||
| args = self.spawner.get_args() | ||
| self.assertIn("--proxy-api-url=http://127.0.0.1:12345/foo/bar/", args) | ||
| self.assertFalse(any("--config-file=" in arg for arg in args)) |
Contributor
There was a problem hiding this comment.
or you could "config-file" in " ".join(args)
Contributor
Author
There was a problem hiding this comment.
Yes, but I think that loops over the content ofargs twice? any returns True for the first True (although if the test should pass, it loops over the whole thing, once).
Contributor
There was a problem hiding this comment.
Are you seriously talking performance on a test that checks if a string is present in a 100 bytes string?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #138