Adding license in readme#169
Merged
Merged
Conversation
Current coverage is 85.08% (diff: 100%)@@ master #169 diff @@
==========================================
Files 36 36
Lines 1374 1374
Methods 0 0
Messages 0 0
Branches 130 130
==========================================
Hits 1169 1169
Misses 166 166
Partials 39 39
|
Contributor
|
Is this included in the sphinx doc? I just tried |
Contributor
Author
|
@kitchoi then why aren't the tests failing? |
Contributor
|
@stefanoborini Tests did not fail because the doc is built successfully. I meant there isn't a page that mentions license on the doc. Isn't it what #142 meant? |
| utilities | ||
| design | ||
| developer | ||
| api |
Contributor
There was a problem hiding this comment.
accidentally removed 'api'?
Contributor
Author
There was a problem hiding this comment.
it's supposed to be (and already present) in developer
Contributor
There was a problem hiding this comment.
But I am used to seeing API at the top of the toc in other documentation, and 'developer' section is meant to contain more content than just a link to API. Maybe it is just me :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #142