Skip to content
This repository was archived by the owner on Apr 23, 2021. It is now read-only.
This repository was archived by the owner on Apr 23, 2021. It is now read-only.

Review of current CUBA keys #77

Description

@kemattil

Few comments/remarks related to the current CUBA keys:

  1. MATERIAL_TYPE:
    definition: Material dimension and type
    shape: [1]
    type: integer

    Is this needed anymore as materials will be defined using the Material class (from metadata)?

    If it is still needed, the definition should be more precise (a single integer
    expressing both the dimension and type of a material?) ...

  2. EQUATION_OF_STATE_COEFFICIENT:
    definition: Equation of state for multiphase fluids
    shape: [1]
    type: double

This is probably not needed anymore, because the equation of state will be
defined using materials relations (i.e. metadata) ...

If it is still needed, the type (scalar double) seems odd for defining
an equation of state ...

  1. HEAT_CONDUCTIVITY:
    definition: Heat conductivity
    shape: [1]
    type: double

Should this be "thermal conductivity" or, e.g., "heat transfer coefficient"?
I mean, is "heat conductivity" a standard physical variable in some field?

  1. Many of the descriptions only repeat the key, do not convey much information,
    or are overly restrictive. See e.g. the VELOCITY below: why only velocity of a
    point or node? VELOCITY can be used to define velocity of anything ...

    VELOCITY:
    definition: Velocity of a point or node
    shape: [3]
    type: double

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions