This repository was archived by the owner on Apr 23, 2021. It is now read-only.
Problem: data property should be a reference#362
Merged
Conversation
Contributor
Author
|
@stefanoborini @ahashibon The regenerate brings in also the |
Contributor
|
Thanks @mehdisadeghi, looks good to me. |
Contributor
|
Ok, now I am confused. Didn't we agree that we had to return a copy? |
Contributor
|
Ok, this PR is doing unrelated things so I will do the following:
On the rest you can discuss it among yourself, and reach a conclusion. |
Contributor
|
I merged master after PR #363 into this one. Now it should just be the "data" change. |
Contributor
Author
|
@stefanoborini This PR is desired since it provides the expected behavior. BTW, I realized even simphony v3.0 has been inconsistent regarding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: revert corresponding change made in #335
@ahashibon @stefanoborini I reverted a changed which was my bad.