Generic interface lattice#327
Conversation
Current coverage is 67.97% (diff: 97.26%)
|
mehdisadeghi
left a comment
There was a problem hiding this comment.
I wrote some comments on #326 which applies here as well.
| """ | ||
|
|
||
| @abstractmethod | ||
| def count_of(self, item_type): # pragma: no cover |
There was a problem hiding this comment.
Please consider that when/if we define Edge, Point, Particle, Bond, Face, Cell and Node in the metadata (some of them are already defined), we have to get rid of CUDSItem enum.
There was a problem hiding this comment.
You mean as CUBA keywords? In that case, we'll have to change the implementation and the accepting value. I'd say we have to keep this as is, or we ruin the current interface, so it's just a step in that direction.
There was a problem hiding this comment.
I totally agree with you. However, we have to come back to this later.
Built on top of #326. Please review that first.
Implements the generic interface for the Lattice object.