This repository was archived by the owner on Apr 23, 2021. It is now read-only.
Fixes incorrect call in _add_mesh#318
Merged
mehdisadeghi merged 4 commits intoAug 25, 2016
Merged
Conversation
I suspect this is supposed to be add_edges...
Member
|
Indeed, copy paste error :( |
Current coverage is 72.04% (diff: 100%)@@ master #318 diff @@
==========================================
Files 107 107
Lines 6795 6810 +15
Methods 0 0
Messages 0 0
Branches 803 806 +3
==========================================
+ Hits 4882 4906 +24
+ Misses 1873 1867 -6
+ Partials 40 37 -3
|
Contributor
Author
|
@roigcarlo which means that some tests are missing in there. I'll fix that, please don't merge. |
Member
|
Sure, I am taking a look at it as well. If I am not mistaken the test should be this one: simphony-common/simphony/testing/abc_check_mesh.py Lines 135 to 144 in 25e25f4 But for some reason is not running properly or is no using edges at all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect this is supposed to be add_edges...