This repository was archived by the owner on Apr 23, 2021. It is now read-only.
add docstrings#154
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
ParticleContainer. Should it be Particles or particle container?
(same question applies to docstring for add_bond)
Contributor
Author
There was a problem hiding this comment.
Good point, I will fix that
Member
There was a problem hiding this comment.
Bond() is missing particles parameter.
should it be something like
bond = Bond(particles=(particle1.uid, particle2.uid))
Member
|
I had just two comments but otherwise, it looks good to me. |
Contributor
Author
|
PR updated |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #153