This repository was archived by the owner on Apr 23, 2021. It is now read-only.
Fix h5mesh data attribute conflict#149
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
I am not sure what is the purpose of this test.
Is this planned to check the duplicated tables of #148?
Contributor
Author
There was a problem hiding this comment.
It is me (going a little overboard) checking that we do not create multiple nodes when we create multiple proxies of an already existing group. It is not directed to check for #148
Member
|
Just a couple of comments, but as soon as it passes Travis 👍 |
Member
|
Just one comment: the hdf5-psuedo-uml diagrams have to be updated with the new name ("item_data") |
Member
|
👍 |
roigcarlo
added a commit
that referenced
this pull request
Jun 1, 2015
Fix h5mesh data attribute conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR fixes #144