PR: Lattice attributes are always 3D.#147
Conversation
for size, origin, etc. Factory functions require 2D size, origin etc for two dimensional lattices. User must _not_ input the extra '1', e.g. (n,m,1), for the size attribute.
|
@itziakos, @roigcarlo, @kemattil here's the initial push to fix #80. I think there are several ways to implement the SSB decision. This is the one I thought was the simplest. Please, take a look. There are no try/exceptions written that test the dimensionality of input parameters, but I think they could be added to the factory functions, at least. Please, let me know if you think that's a good idea to do. |
I am in favor of not overdoing it also. |
There was a problem hiding this comment.
I think origin should be x, y, z
There was a problem hiding this comment.
You're right. Docstrings already say that the lattice will be embedded in 3D so the origin must be in 3D.
lattice attributes.
PR: Lattice attributes are always 3D.
This PR fixed #80. Please, note that documentation is not modified yet.
Changes:
abstractlattice.py:
lattice.py:
test_lattice.py:
h5lattice.py:
abc_check_lattice.py: