Internal links on plugin READMEs are broken

[simonw]

For example https://datasette.io/plugins/datasette-graphql - the contents on that page links to https://datasette.io/plugins/datasette-graphql#filtering-tables but that URL doesn't resolve to an ID on the page.

Turns out the HTML returned by the GitHub README API has this:

<li><a href="#filtering-tables">Filtering tables</a></li>
...
<h3><a id="user-content-filtering-tables" class="anchor" aria-hidden="true" href="#filtering-tables"><svg class="octicon octicon-link" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M7.775 3.275a.75.75 0 001.06 1.06l1.25-1.25a2 2 0 112.83 2.83l-2.5 2.5a2 2 0 01-2.83 0 .75.75 0 00-1.06 1.06 3.5 3.5 0 004.95 0l2.5-2.5a3.5 3.5 0 00-4.95-4.95l-1.25 1.25zm-4.69 9.64a2 2 0 010-2.83l2.5-2.5a2 2 0 012.83 0 .75.75 0 001.06-1.06 3.5 3.5 0 00-4.95 0l-2.5 2.5a3.5 3.5 0 004.95 4.95l1.25-1.25a.75.75 0 00-1.06-1.06l-1.25 1.25a2 2 0 01-2.83 0z"></path></svg></a>Filtering tables</h3>

So this is a bug in GitHub's API, but we need to work around it.

[simonw]

I could run the HTML through BeautifulSoup and fix any link to #something that doesnt start with #user-content-`.

[simonw]

I'd rather not have to run a Soup parser on every request to that page, so I may do this as a transformation when I write the README's HTML to the database. Could even be a github-to-sqlite feature.

[simonw]

I'm going to handle this in github-to-sqlite.

[simonw]

Now I can run https://github.com/simonw/datasette.io/actions?query=workflow%3ADeploy like this:

[simonw]

Fixed: https://datasette.io/plugins/datasette-graphql#user-content-accessing-nested-objects