Skip to content

Fix Installer Builds: Test in a separate step #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
papeh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Installer Builds: Test in a separate step #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3629d7b
Fix Installer Builds: Test in a separate step
papeh Mar 10, 2026
affba58
Include more test categories
papeh Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
id: managed_build
shell: powershell
run: |
.\build.ps1 -Configuration Debug -Platform x64 -BuildTests
.\build.ps1 -Configuration Debug -BuildTests
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }

- name: Run managed tests
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/base-installer-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,17 @@ jobs:
echo "C:\Program Files (x86)\WiX Toolset v3.11\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
if: github.event_name != 'pull_request'

- name: Build and run tests
- name: Build
id: build_installer
shell: powershell
run: |
.\build.ps1 -BuildInstaller -Configuration Release -Verbosity detailed -RunTests -TestFilter 'TestCategory!=ByHand&TestCategory!=SmokeTest&TestCategory!=DesktopRequired' `
-MsBuildArgs @("/bl") | Tee-Object -FilePath build.log
.\build.ps1 -BuildInstaller -Configuration Release -Verbosity detailed -BuildTests -MsBuildArgs @("/bl") | Tee-Object -FilePath build.log

- name: Run tests
id: run_tests
shell: powershell
run: |
.\test.ps1 -Configuration Release -NoBuild -TestFilter 'TestCategory!=DesktopRequired' | Tee-Object -FilePath build.log -Append

- name: Scan Build Output
shell: powershell
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/patch-installer-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,13 +220,18 @@ jobs:
New-ItemProperty -Path $path -Name $valueName -Value $expectedValue -Type String -Force
}

- name: Build and Run Tests
- name: Build
id: build_installer
shell: powershell
run: |
Get-ItemProperty -Path "HKLM:\SOFTWARE\Microsoft\.NETFramework\AppContext"
.\build.ps1 -BuildPatch -Configuration Release -Verbosity detailed -RunTests -TestFilter 'TestCategory!=ByHand&TestCategory!=SmokeTest&TestCategory!=DesktopRequired' `
-MsBuildArgs @("/bl") | Tee-Object -FilePath build.log
.\build.ps1 -BuildPatch -Configuration Release -Verbosity detailed -BuildTests -MsBuildArgs @("/bl") | Tee-Object -FilePath build.log

- name: Run tests
id: run_tests
shell: powershell
run: |
.\test.ps1 -Configuration Release -NoBuild -TestFilter 'TestCategory!=DesktopRequired' | Tee-Object -FilePath build.log -Append

- name: Scan Build Output
shell: powershell
Expand Down
Loading