LT-22448: Implement ItemDataModified in Pub/Sub system

[mark-sil]

This change is 

[github-actions]

NUnit Tests

    1 files  ±0      1 suites  ±0   5m 49s ⏱️ -4s
4 407 tests ±0  4 320 ✅ ±0  87 💤 ±0  0 ❌ ±0 
4 416 runs  ±0  4 329 ✅ ±0  87 💤 ±0  0 ❌ ±0 

Results for commit 2b410af. ± Comparison against base commit bcfbea0.

♻️ This comment has been updated with latest results.

[jasonleenaylor]

@jasonleenaylor reviewed 2 files and made 1 comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on mark-sil).

---

Src/xWorks/RecordClerk.cs line 312 at r1 (raw file):

				if (decorator == null)
					break;
				da = decorator.BaseSda;

I think the RecordClerk is not the class that should actually be subscribing. The decorator that implements OnItemDataModified should actually be the one subscribed eliminating all this ugliness. May as well do that.

Code quote:

			var da = m_list.VirtualListPublisher;
			while (da != null)
			{
				if (da.GetType().GetMethod("OnItemDataModified") != null)
					ReflectionHelper.CallMethod(da, "OnItemDataModified", new [] {argument});
				var decorator = da as DomainDataByFlidDecoratorBase;
				if (decorator == null)
					break;
				da = decorator.BaseSda;

[mark-sil]

@mark-sil made 1 comment.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on jasonleenaylor).

---

Src/xWorks/RecordClerk.cs line 312 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

I think the RecordClerk is not the class that should actually be subscribing. The decorator that implements OnItemDataModified should actually be the one subscribed eliminating all this ugliness. May as well do that.

I agree, that is a much cleaner solution. I moved the subscribing to the ConcDecorator.