Skip to content

feat!: BREAKING CHANGE: Support webpack@5 typings#289

Merged
shellscape merged 2 commits into
shellscape:masterfrom
SunHuawei:master
Mar 8, 2022
Merged

feat!: BREAKING CHANGE: Support webpack@5 typings#289
shellscape merged 2 commits into
shellscape:masterfrom
SunHuawei:master

Conversation

@SunHuawei

@SunHuawei SunHuawei commented Feb 22, 2022

Copy link
Copy Markdown
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:
#279

Description

As you've known that webpack@5 is having a totally different typing definition, and there is no way to support v4 and v5 at the same time. So one choice is just to release a major version to only support webpack 5.

BREAKING CHANGES: removed webpack@4 support
@SunHuawei SunHuawei changed the title Support webpack@5 typings BREAKING CHANGE: Support webpack@5 typings Feb 22, 2022
@SunHuawei

Copy link
Copy Markdown
Contributor Author

@shellscape , there are 3 workflows awaiting approval, would you please help with this?

@nigelellis

Copy link
Copy Markdown

We're hitting this in a recent version bump. Anything I can do to help get this PR merged?

@SunHuawei

Copy link
Copy Markdown
Contributor Author

I'm still waiting for the owner to approve the workflow.
@nigel-codaio, here is the npm package published from my forked repo. You can use npm i webpack-manifest-plugin-v5 for a temporary solution.

@shellscape shellscape changed the title BREAKING CHANGE: Support webpack@5 typings feat!: BREAKING CHANGE: Support webpack@5 typings Mar 2, 2022
@shellscape
shellscape merged commit 6a475c8 into shellscape:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants