Fix compatibility with numpy 2.1 dev to cast GeometryType to int as ufunc input#2099
Conversation
Pull Request Test Coverage Report for Build 10262405824Details
💛 - Coveralls |
mwtoews
left a comment
There was a problem hiding this comment.
Agree this is the correct cast type, and is consistent with other ufunc enums.
After merge, this should be cherry-picked into maint-2.0 to resolve CI failures too.
|
It's a bit weird that NumPy 2.1 breaks stuff right, as a minor release? Anyway, since NumPy could release 2.1 at any moment, could a new release be tagged, either to Shapely 2.0.x with a backport or Shapely 2.1? |
|
If all else is not feasible, could we set NumPy to <2.1 on the Shapely 2.0 branch and sprint a release out? Line 46 in 2a83905 |
|
NumPy just released 2.1.0, and I noticed this impacting my code. It would be nice to get a release out. @EwoutH - Impressive that you guessed "NumPy could release 2.1 at any moment" <4 hours before they released it. |
|
What’s the strangest is that @jorisvandenbossche added this to the 2.0.6 milestone over two weeks ago, but 2.0.6 was never released. |
|
Will 2.0.6 be released or what is missing from that being released? |
That's because milestones are used for future releases ;) We were planning to cut a 2.0.6 release if needed (if numpy 2.1 was released before a next shapely release), which is the case now, so will try to do that the coming hours. |
|
Shapely 2.0.6 is released (it's on pypi, conda-forge can still take a few hours) |
Fixes #2098