Allows all PWA options to work

[lukasdotcom]

In release 5.5.5 the disable option was broken. This fixes the option and allows it to work again.
Edit: Turns out all of the options specified do not work in 5.5.5. This should fix this.
Resolves: #371
Resolves: #370
Resolves: #378

[theoludwig]

LGTM! 👍
Thanks, it solves the issue.

Just tested by manually editing my node_modules. 😄

[sanderkooger]

Just subscribing so i know when this is merged. Having th same issue

[MaheshtheDev]

Just subscribing to know when this will merge, because having same issue

[digitaluprising]

LGTM

[PicchiKevin]

👍

[brenopolanski]

Just tested by manually editing my node_modules.

I did the same test and it worked 😄

i'm using [email protected] & next-pwa@^5.5.5

[vdjurdjevic]

Just subscribing to know when this will merge

[theoludwig]

cc @shadowwalker

[bdlb77]

+1 to changes in source code working via manual change to my node_modules

[d-strygwyr]

LGTM !

[d3ni00]

For me, #381 is more the next.js way to fix it.

[Diesmo]

For me, #381 is more the next.js way to fix it.

I agree with this.
This PR here is merely a hotfix/workaround for the breaking change introduced in v5.5.5 because of the next.js changes.

#381 on the other hand is dealing with the config how next.js intented it (at least thats how I understood the next.js changes that lead to the situation we are in now)

I suggest to merge #381 instead of this PR here.

[brenopolanski]

For me, #381 is more the next.js way to fix it.

Yeah! Looking at the changes in PR #381 I also agree that it's the best way to fix the issue.

[lekipising]

Having same issue, subscribing

[kirkegaard]

LGTM

[shadowwalker]

OK, I have read through the discussions and code changes in these PRs:

• Allows all PWA options to work #372
• resolve next config being deleted problem #381
• Fix pwa configuration, current release only works with default values #384

I will take this PR as it's minimal change and doesn't include format changes, will release a patch version 5.5.6.

Beside will make a new breaking change and release version 5.6.0 soon. Following the guidance from official plugin implementation.