Added last_active and removed pruning from ConvoInfoVolatile#51
Closed
mpretty-cyro wants to merge 3 commits intosession-foundation:devfrom
Closed
Added last_active and removed pruning from ConvoInfoVolatile#51mpretty-cyro wants to merge 3 commits intosession-foundation:devfrom
last_active and removed pruning from ConvoInfoVolatile#51mpretty-cyro wants to merge 3 commits intosession-foundation:devfrom
Conversation
jagerman
reviewed
Jun 16, 2025
| /// r - the unix timestamp (in integer milliseconds) of the last-read message. Always | ||
| /// included, but will be 0 if no messages are read. | ||
| /// l - the unix timestamp (in integer milliseconds) the conversation was last active. Always | ||
| /// included, but will be 0 for empty conversations. |
Member
There was a problem hiding this comment.
We should make just one of these two always included and omit the other when 0. (The reason to always include something is that we have to ensure there is always one value, because empty dicts get pruned from the serialized config).
Collaborator
Author
|
Closing this for the time being and leaving sorting up to the clients - once |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.