This repository was archived by the owner on Jul 10, 2023. It is now read-only.
Replace deprecated Matrix4 with Matrix4D#235
Merged
Merged
Conversation
Contributor
|
This looks like it failed on serde/aster/quasi stuff when the plugins feature is enabled. Perhaps the version requirements need to be adjusted in Cargo.toml? |
Contributor
Author
|
I think fix for this is in servo/ipc-channel#68 (comment). |
Contributor
|
Ok. We can retry once that lands. r=me when that happens. |
Contributor
Author
|
Building is fixed now. |
Member
|
@bors-servo: r=metajack |
|
📌 Commit 23008f8 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 4, 2016
Replace deprecated Matrix4 with Matrix4D <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-layers/235) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is