feat: Replace the agent DSL with a composite of instanceId and task name#967
Conversation
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
treblereel
left a comment
There was a problem hiding this comment.
I see no issues with this PR, great job!
|
@ricardozanini hhhm, I did not really get that one. A task is already unique by combining the existing instanceid and the task position. The task position, as per spec, is a json pointer. The task name, in itself, is not unique. You might have th4e same task name in different positions. The position can be obtained calling |
experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java
Outdated
Show resolved
Hide resolved
...imental/fluent/func/src/test/java/io/serverlessworkflow/fluent/func/FuncDSLUniqueIdTest.java
Outdated
Show resolved
Hide resolved
...imental/fluent/func/src/test/java/io/serverlessworkflow/fluent/func/FuncDSLUniqueIdTest.java
Outdated
Show resolved
Hide resolved
...ntal/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/UniqueIdBiFunction.java
Outdated
Show resolved
Hide resolved
|
hmm it's true, task name is not unique 😮💨 |
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
|
@fjtirado mind taking a second look? |
...ntal/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/UniqueIdBiFunction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
In this PR, we are replacing the
agentDSL with a unique composite ID referencing the instance ID and the task name, so we guarantee uniqueness to the@MemoryIdarguments when calling agent methods.Special notes for reviewers:
Additional information (if needed):