Use Spoteless for header checking and code-formatting#721
Use Spoteless for header checking and code-formatting#721ricardozanini merged 3 commits intoserverlessworkflow:mainfrom
Conversation
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
|
I'll fix the error tomorrow. Actually, there's a bug on our CI. The |
|
@ricardozanini I did a a quick check using Eclipse (I was not using command line for anything till now) and it was not good (I have to start using command line) After executing make hooks (which is not automatized by Eclipse, so command line), I added a file without header in Eclipse, add to stage the new file and the header was not added. I still has to add it manually or execute make checks (I did not find a way to invoke make checks from Eclipse, I have to use the command line. Funny thing is that I realized I have not had the need to install maven till now, it was enough with the Eclipse embedded one) |
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
|
Hey @fjtirado thanks for testing it!
|
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
In this PR:
make help)Special notes for reviewers:
@fjtirado if you agree, feel free to merge.
Additional information (if needed):
Since the project is growing, I believe we should start to improve the governance.
PS: I intend to change this formatter. The Google one is too narrow IMO.