Initial CallChatModel implementation#668
Closed
treblereel wants to merge 7 commits intoserverlessworkflow:mainfrom
Closed
Initial CallChatModel implementation#668treblereel wants to merge 7 commits intoserverlessworkflow:mainfrom
treblereel wants to merge 7 commits intoserverlessworkflow:mainfrom
Conversation
fjtirado
requested changes
Jul 24, 2025
Collaborator
fjtirado
left a comment
There was a problem hiding this comment.
Im going to open a PR over this branch
experimental/ai/impl/pom.xml
Outdated
Comment on lines
22
to
25
| <dependency> | ||
| <groupId>io.serverlessworkflow</groupId> | ||
| <artifactId>serverlessworkflow-experimental-types</artifactId> | ||
| </dependency> |
Collaborator
There was a problem hiding this comment.
This dependency is duplicated
experimental/ai/impl/pom.xml
Outdated
| <groupId>dev.langchain4j</groupId> | ||
| <artifactId>langchain4j</artifactId> | ||
| <version>1.1.0</version> | ||
| <optional>true</optional> |
|
|
||
| package io.serverlessworkflow.impl.executors.ai; | ||
|
|
||
| public abstract class AbstractCallAIChatModelExecutor<T> { |
Collaborator
There was a problem hiding this comment.
This should be an interface, not an abstract class. so it should be renamed as AIChatModelExecutor
And it can extends BiFunction<T,Object,Object>, not define the apply
Collaborator
|
I created PR treblereel#1 as code review |
97b96a4 to
87a617a
Compare
Collaborator
|
@treblereel I have created treblereel#2 with code review comments. Please merge over this. It contains changes in the structure of the CallableTask implementation. It is important to not mix the build part (where the executor should be created) with the execution part (when it is run) This is aligned with #675 |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):