Fix ArithmeticException crash in div_zero button click handler - #241
Open
sentry[bot] wants to merge 1 commit into
Open
Fix ArithmeticException crash in div_zero button click handler#241sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Wrap the divide-by-zero operation in a try-catch block so the ArithmeticException is captured and reported to Sentry instead of crashing the app. This follows the same handled-exception pattern already used by the handled_exception button. Fixes [ANDROID-K3](https://demo.sentry.io/issues/7623024397/)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 883 886 +3
Branches 67 67
=====================================
- Misses 883 886 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nThe
div_zerobutton's click listener inMainActivitycontained a hardcodedint t = 5 / 0that threw an unhandledArithmeticException, crashing the app.\n\n## Fix\n\nWrap the divide-by-zero operation in atry-catchblock so theArithmeticExceptionis caught and reported to Sentry viaSentry.captureException(e)instead of crashing the app. This follows the same handled-exception pattern already used by thehandled_exceptionbutton.\n\nFixes ANDROID-K3