Fix IllegalArgumentException when dismissing ProgressDialog after lifecycle changes - #231
Draft
cursor[bot] wants to merge 1 commit into
Conversation
…ecycle changes Add lifecycle-aware dialog dismissal to prevent crashes when the activity/fragment is destroyed or recreated during async network calls. Changes: - Add dismissProgressDialogSafely() helper method that checks isAdded() and isDetached() - Add dismissCheckoutProgressDialogSafely() for checkout flow - Ensure all dialog dismiss calls happen on the UI thread - Remove duplicate progressDialog.dismiss() call in fetchToolsFromServer - Add try-catch blocks to handle edge cases during dismissal Fixes [ANDROID-EW](https://demo.sentry.io/issues/7431031780/)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 875 884 +9
Branches 65 65
=====================================
- Misses 875 884 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an
IllegalArgumentExceptionthat occurs whenProgressDialog.dismiss()is called after the activity/fragment has been destroyed or recreated (e.g., during device rotation or navigation).Root Cause
The issue occurred because:
ProgressDialog.dismiss()was being called from OkHttp network callbacks afterEmpowerPlantActivity/MainFragmentwas destroyed/recreatedDecorViewwas no longer attached to theWindowManagerwhen dismiss was calleddismiss()call existed in thefetchToolsFromServer()methodChanges
dismissProgressDialogSafely()helper method that checks:isAdded())!isDetached())isShowing())dismissCheckoutProgressDialogSafely()for the checkout flowrunOnUiThread()progressDialog.dismiss()call infetchToolsFromServer()progressDialogvariable incheckout()tocheckoutProgressDialogto avoid confusionTesting
To reproduce the original issue:
EmpowerPlantActivitywhich loadsMainFragmentProgressDialogis showing, rotate the device or navigate awayIllegalArgumentExceptionWith this fix, the dialog dismissal is safely skipped if the fragment is no longer attached.
Fixes ANDROID-EW