Skip to content

2024 10 iri improvements#2

Merged
cmutel merged 10 commits into
sentier-dev:mainfrom
simonvanlierde:2024-10-IRI-improvements
Oct 9, 2024
Merged

2024 10 iri improvements#2
cmutel merged 10 commits into
sentier-dev:mainfrom
simonvanlierde:2024-10-IRI-improvements

Conversation

@simonvanlierde

@simonvanlierde simonvanlierde commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

Description

This pull request includes some updates to the IRI class methods in the sentier_data_tools package, focusing on improving the flexibility and clarity of the VocabIRI base class. I've added docstrings, a triple position enum for flexibility, and some unit tests for the IRI classes. I've tried to use clear commit messages, which can aid in reviewing this PR.

New Functionality:

  • sentier_data_tools/utils.py: Introduced a new enumeration TriplePosition to represent the position of an object in a triple store, making the IRI-based queries more flexible.

Testing:

  • tests/test_iri_utils.py: Added unit tests for the convert_json_object function, the ProductIRI.triples method, and the VocabIRI error handling when the graph_url attribute is missing.

Bug Fixes:

  • README.md: Corrected the file extension for the Conda environment file from .yml to .yaml.
  • .gitignore: Added standard MacOS and VS code file patterns.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

  • I'm aware of the code of conduct.
  • I'm aware of the contributing guidelines.
  • I've created logical separate commits and followed the commit message format.
  • If this PR resolves or addresses an issue, I've linked it in the commit message.
  • I've added relevant test cases.
  • I've added relevant documentation.
  • I've NOT included third-party code (copy/pasted source code or new dependencies).
    • If you have added third-party code (copy/pasted or new dependencies), please make sure this has been discussed in a github issue.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@cmutel
cmutel merged commit eb341d1 into sentier-dev:main Oct 9, 2024
@cmutel

cmutel commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

@simonvanlierde Are you F-n kidding me? This is amazing!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants