2024 10 iri improvements#2
Merged
cmutel merged 10 commits intoOct 9, 2024
Merged
Conversation
Contributor
|
@simonvanlierde Are you F-n kidding me? This is amazing!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes some updates to the IRI class methods in the
sentier_data_toolspackage, focusing on improving the flexibility and clarity of theVocabIRIbase class. I've added docstrings, a triple position enum for flexibility, and some unit tests for the IRI classes. I've tried to use clear commit messages, which can aid in reviewing this PR.New Functionality:
sentier_data_tools/utils.py: Introduced a new enumerationTriplePositionto represent the position of an object in a triple store, making the IRI-based queries more flexible.Testing:
tests/test_iri_utils.py: Added unit tests for theconvert_json_objectfunction, theProductIRI.triplesmethod, and theVocabIRIerror handling when thegraph_urlattribute is missing.Bug Fixes:
README.md: Corrected the file extension for the Conda environment file from.ymlto.yaml..gitignore: Added standard MacOS and VS code file patterns.Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: