Skip to content

Added Code Review to Contributing.md #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mptap wants to merge 2 commits into from
Closed

Added Code Review to Contributing.md #58

mptap wants to merge 2 commits into from

Conversation

@mptap
Copy link

@mptap mptap commented Oct 31, 2017 •
edited
Loading

Fixes #57

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Added Code Review to Contributing.md

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@mptap mptap mentioned this pull request Oct 31, 2017
Closed
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Mar 6, 2018
@childish-sambino childish-sambino removed the type: docs update documentation change not affecting the code label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:37
@childish-sambino
Copy link

childish-sambino commented Sep 21, 2020

Duplicate of #83

@childish-sambino childish-sambino marked this as a duplicate of #83 Sep 21, 2020
@childish-sambino childish-sambino added status: duplicate duplicate issue and removed difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio labels Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: duplicate duplicate issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Code Review to Contributing.md

4 participants

@mptap @childish-sambino @thinkingserious @mbernier